-
Notifications
You must be signed in to change notification settings - Fork 5.2k
docs: minor-styling #16109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: minor-styling #16109
Conversation
- updated nine years to ten years of Ethereum
…pace around links to other pages for consistency across other pages
✅ Deploy Preview for ethereumorg canceled.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @pete-vielhaber!
Usage | Instances |
---|---|
e.g. |
270 |
e.g., |
125 |
i.e. |
186 |
i.e., |
96 |
Cursory search of the repo shows this breakdown, so it's not exactly standardized throughout the site. Despite my personal preference to not use a comma since it feels superfluous 😉, standard in American English (used by this website) would suggest we standardize around e.g.,
for examples and i.e.,
for clarifications and restatements.
No worries that this PR doesn't grep the whole repo—makes the review much more concise. I would welcome to a separate issue/PR to update our content standardization guidelines (public/content/contributing/style-guide/content-standardization/index.md
viewable at https://ethereum.org/contributing/style-guide/content-standardization) to note this, and to update any English copy to conform to these guidelines. Any interest??
Otherwise just a couple comments / questions and then this is good to go.. thanks for the help!
- [Besu](https://www.hyperledger.org/use/besu) | ||
|
||
[Nethermind](https://downloads.nethermind.io/) | ||
- [Nethermind](https://downloads.nethermind.io/) | ||
|
||
[Erigon](https://github.com/ledgerwatch/erigon) | ||
- [Erigon](https://github.com/ledgerwatch/erigon) | ||
|
||
[Go-Ethereum](https://geth.ethereum.org/) | ||
- [Go-Ethereum](https://geth.ethereum.org/) | ||
|
||
[Reth](https://reth.rs/) | ||
- [Reth](https://reth.rs/) | ||
|
||
### Consensus clients {#consensus-clients} | ||
|
||
[Nimbus](https://nimbus.team/) | ||
- [Nimbus](https://nimbus.team/) | ||
|
||
[Lighthouse](https://github.com/sigp/lighthouse) | ||
- [Lighthouse](https://github.com/sigp/lighthouse) | ||
|
||
[Teku](https://consensys.net/knowledge-base/ethereum-2/teku/) | ||
- [Teku](https://consensys.net/knowledge-base/ethereum-2/teku/) | ||
|
||
[Lodestar](https://github.com/ChainSafe/lodestar) | ||
- [Lodestar](https://github.com/ChainSafe/lodestar) | ||
|
||
[Prysm](https://docs.prylabs.network/docs/getting-started) | ||
- [Prysm](https://docs.prylabs.network/docs/getting-started) | ||
|
||
[Grandine](https://docs.grandine.io/) | ||
- [Grandine](https://docs.grandine.io/) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm, could clean up the whitespace between these as well as we typically write lists without empty lines between... will render the same, so just a small nit-pick
@wackerow I'll take a stab at updating the guidelines for hard stops and updating the rest of the e.g. and i.e.'s to get commas in a separate PR |
public/content/developers/docs/nodes-and-clients/run-a-node/index.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm! Thanks @pete-vielhaber
Congrats, your important contribution to this open-source project has earned you a GitPOAP! GitPOAP: 2025 Ethereum.org Contributor: Join the [ethereum.org Discord server](https://ethereum.org/discord) to explore more ways to contribute to the project. Depending on the tasks you complete, you may also unlock additional rewards. Visit [ethereum.org/contributing](https://ethereum.org/contributing) to learn more.Head to gitpoap.io & connect your GitHub account to mint!Keep buidling, keep learning, and let's grow the Ethereum open-source community together 🌱 Learn more about GitPOAPs here. |
@all-contributors please add @pete-vielhaber for maintenance |
I've put up a pull request to add @pete-vielhaber! 🎉 |
Description
Related Issue
No related issues